Week #3 Status Report

-
This was the third week since the commencement of official coding period on 1st June. In the last three weeks a lot of work is done and a lot of work still remains. The phase 1 evaluation submissions shall begin from monday next week, so now just 7 days are remaining.

This week was mostly spent on accommodating review changes by my mentors and writing some unit tests.

Work Done:

Tests: 

I started my week writing some unit tests for the draw_dab and get_color methods that I had implemented previous to previous week.

Refactoring: 

Boud suggested me to do some refactoring as the design decisions of my previous approach were not that good. I had linked libmypaint to other component responsible for preset management in the code which was not the right thing to do as a good design would be to have all the dependencies that belong to a plugin contained in the plugin itself. Ideally, a plugin should be removable from the entire system by deleting or commenting a single line. So, I had to implement a separate paintop factory class and hook the plugin within this class. Boud gave me an entire archive with code to the previous mypaint plugin that we had in Krita years ago. So, this was nothing more than understanding its approach and implement the same thing.

Profiling: 

In my previous post I had mentioned that the brush engine is lagging. My mentors suggested me to profile the brush strokes as it would reveal the bottlenecks. I did the same and as it turned out that 3 specific methods (KoColor::toQcolor, KoColor::fromQcolor and KoColor(colorspace)) were responsible for the drag. These methods are designed in a manner that they do colorspace conversions for us so that the user can stay away from the dirty work. The problem with using these methods was that they were doing complex processing for something as simple as divide by 255.0f causing the strokes to lag a lot. To mitigate this, I simply removed those methods and did the operation manually which solved the problem. So the lag is much less severe now. 

In short, the week was mostly good, and it went as expected :)

Comments

Post a Comment

Popular posts from this blog

MyPaint Brush Engine Phase #2 Report

-
Image
This is the last week before the phase 2 in Google Summer Code ends. This phase my area of focus was the preset editor, which would enable the user for modifying existing and creating new MyPaint brushes. I went on to extend the same than the one mentioned in my proposal to include more diverse variety of options and settings so that the editor gives us the provision to make much larger scale of changes and exercise complete customization control over the brush engine. It later on became a bit more complicated than I had expected it to be initially which led to a lot of bugs and crashes. It works fine now, mostly:) There is still one last bug that I need to eliminate, though. Basic Options Preset Editor Overall, this was a good month :) 
Read more

Week #6 Progress [MyPaint Engine]

-
Image
Last week my prime focus was to add more and more settings in the preset editor and so as to make mypaint brushes a bit more customizable. I used KisCurveOptionWidget class which Krita already has and modified it so that it can accomodate the settings and dynamic mypaint brush options. This went on to become a lot more complicated than I anticipated. Although, it works fine there are still a lot of bugs and finishing required to mark this as complete. Preset Editor  This is the layout of how the preset editor looks like and it is still far from complete. I need to categorise all the settings in the form of a tree view. I am also quite sceptical about the way of handling mypaint settings internally. I will check if that is right or some alternative approach would be a better fit and make the required changes. I will look at all those things this week. If everything goes fine this would be complete by this week's end. Till then, Good Bye :)
Read more

MyPaint Brush Engine Phase #3 Report

-
 Today is the last day of google summer of code 2020.  This month, I have completed the following tasks: Refactorizing MyPaint plugin for master: I started the month, working on refactorization of the MyPaint brush engine for master branch. This is functional. Though I will have to add the newly committed changes in this branch as well. Refactorizing the MyPaint curve option code with normal curve option code: I had rewritten the curve option widget code due to some clashes with enums, while the ideal way should have been to share this with the existing code. I spent the next week completing this. Documenting the brush engine was already in my todo. I had to create a page for MyPaint brush engine in Krita manual, in its brush engine section. The merge request got approved yesterday. Support for higher bit depths and other color models: Given that MyPaint is an RGB editor it can't work properly for other color models. So I need to disable it for other color models. This is still a w
Read more